fix: only block release on fixed issues with higher severity than low #179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obs-gh-mattcotter
force-pushed
the
mc/vuln-check
branch
2 times, most recently
from
ec68dad to
b40a603
Compare
obs-gh-mattcotter
force-pushed
the
mc/vuln-check
branch
from
b40a603 to
390bd04
Compare
obs-gh-mattcotter
changed the title
obs-gh-alexlew
approved these changes
Mar 20, 2025
| @@ -7,11 +7,6 @@ on: | |||
| description: "The branch on which to run the vulnerability check" | |||
| required: true | |||
| default: "main" | |||
| workflow_call: | |||
There was a problem hiding this comment.
why are we removing this from the full check? I'd still maybe want to run this against an arbitrary branch
There was a problem hiding this comment.
Manual runs go through the workflow_dispatch (https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#workflow_dispatch), which still has the branch input above.
If we think we would call this full run workflow as a step in a different workflow, then I can leave in the workflow_call. I didn't foresee that happening though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Only block release on fixed issues with higher severity than low. This will ensure we can still release in the 180 day window we have to fix low severity issues, or when we know about an issue that has no fix.